Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set flux default stop time to dusk #12062

Merged
merged 1 commit into from Jan 31, 2018

Conversation

Projects
None yet
3 participants
@infernix
Copy link
Contributor

commented Jan 30, 2018

Description:

Flux defaults to 22:00 as its stop time, but generally light temperature transitions happen from sunrise to sunset and from sunset to dusk.

This sets the default stop_time to dusk, but still allows for a custom configured stop_time.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4553>

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.
Set flux default stop time to dusk
This is more in line with how one would expect light temperature
transitions to take place, but still allows for a user defined
stop_time.
@homeassistant

This comment has been minimized.

Copy link

commented Jan 30, 2018

Hi @infernix,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@fabaff

fabaff approved these changes Jan 31, 2018

Copy link
Member

left a comment

Looks good to me 🐦

@fabaff fabaff merged commit 6ae3fa4 into home-assistant:dev Jan 31, 2018

5 checks passed

WIP ready for review
Details
cla-bot All contributors have signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0009%) to 93.876%
Details
hound No violations found. Woof!

@balloob balloob referenced this pull request Feb 9, 2018

Merged

0.63 #12267

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.