Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for "off" function #12109

Merged

Conversation

Projects
None yet
3 participants
@lexam79
Copy link
Contributor

commented Feb 1, 2018

Description:

Adds "off" support to the iTunes component

Related issue (if applicable): fixes #7614

Checklist:

  • The code change is tested and works locally.
@bitglue
Copy link
Member

left a comment

Does it make sense to map "turn off" to "stop"?

@lexam79

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2018

To me it does, as it's essentially the closest thing you can do with the API to turning the player off.

@bitglue bitglue merged commit 87c0fd9 into home-assistant:dev Feb 2, 2018

5 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.006%) to 93.88%
Details
hound No violations found. Woof!
@bitglue

This comment has been minimized.

Copy link
Member

commented Feb 2, 2018

It's a bummer this file doesn't have tests, but this looks pretty straightforward. Thanks for the patch!

@lexam79 lexam79 deleted the lexam79:add-support-for-off-state-to-itunes branch Feb 2, 2018

@balloob balloob referenced this pull request Feb 9, 2018

Merged

0.63 #12267

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.