Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device_tracker.asuswrt: Clean up unused connection param #12262

Merged
merged 1 commit into from Feb 9, 2018

Conversation

Projects
None yet
3 participants
@trisk
Copy link
Contributor

commented Feb 9, 2018

Description:

This removes the ap parameter for the SshConnection and TelnetConnection class methods. This parameter is used to assign the _ap attribute as a boolean, which is never used. (The ap configuration parameter check uses the mode attribute of AsusWrtDeviceScanner).

Checklist:

  • The code change is tested and works locally.

If the code communicates with devices, web services, or third-party tools:

  • [x ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@balloob balloob merged commit 1db4df6 into home-assistant:dev Feb 9, 2018

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
coverage/coveralls Coverage decreased (-0.01%) to 93.943%
Details
hound No violations found. Woof!

@trisk trisk deleted the trisk:asuswrt_unused_connection_param branch Feb 9, 2018

hmn added a commit to hmn/home-assistant-dev that referenced this pull request Feb 11, 2018

Merge branch 'dev' into smappee
* dev: (313 commits)
  check_config check bootstrap errors (home-assistant#12291)
  have climate fallback to state if no ATTR_OPERATION_MODE (home-assistant#12271) (home-assistant#12279)
  Update limitlessled requirement to v1.0.9 (home-assistant#12275)
  Retry keyset cloud (home-assistant#12270)
  allow wildcards in subscription (home-assistant#12247)
  Update limitlessled requirement to v1.0.9 (home-assistant#12275)
  Retry keyset cloud (home-assistant#12270)
  Fix some rfxtrx devices with multiple sensors (home-assistant#12264)
  allow wildcards in subscription (home-assistant#12247)
  device_tracker.asuswrt: Clean up unused connection param (home-assistant#12262)
  Version bump to 0.64.0.dev0
  Version bump to 0.63
  One bug fix and one improvement to the statistics sensor. (home-assistant#12259)
  Update frontend to 20180209.0
  Fix duplicate entity_ids in System Monitor (home-assistant#12124)
  Fix for iTunes media player not updating artwork (home-assistant#12089)
  Update owntracks.py (home-assistant#12260)
  Update pyhomematic to 0.1.39 (home-assistant#12265)
  miflora - fix for exception handling bug (home-assistant#12149)
  Fix source code using Windows newline (home-assistant#12248)
  ...

hmn added a commit to hmn/home-assistant-dev that referenced this pull request Feb 11, 2018

Merge branch 'dev' into ps4
* dev: (190 commits)
  check_config check bootstrap errors (home-assistant#12291)
  have climate fallback to state if no ATTR_OPERATION_MODE (home-assistant#12271) (home-assistant#12279)
  Update limitlessled requirement to v1.0.9 (home-assistant#12275)
  Retry keyset cloud (home-assistant#12270)
  allow wildcards in subscription (home-assistant#12247)
  Update limitlessled requirement to v1.0.9 (home-assistant#12275)
  Retry keyset cloud (home-assistant#12270)
  Fix some rfxtrx devices with multiple sensors (home-assistant#12264)
  allow wildcards in subscription (home-assistant#12247)
  device_tracker.asuswrt: Clean up unused connection param (home-assistant#12262)
  Version bump to 0.64.0.dev0
  Version bump to 0.63
  One bug fix and one improvement to the statistics sensor. (home-assistant#12259)
  Update frontend to 20180209.0
  Fix duplicate entity_ids in System Monitor (home-assistant#12124)
  Fix for iTunes media player not updating artwork (home-assistant#12089)
  Update owntracks.py (home-assistant#12260)
  Update pyhomematic to 0.1.39 (home-assistant#12265)
  miflora - fix for exception handling bug (home-assistant#12149)
  Fix source code using Windows newline (home-assistant#12248)
  ...

@balloob balloob referenced this pull request Feb 22, 2018

Merged

0.64.0 #12609

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.