Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update limitlessled requirement to v1.0.9 #12275

Merged
merged 3 commits into from Feb 10, 2018

Conversation

Projects
None yet
5 participants
@vaceslav
Copy link
Contributor

commented Feb 10, 2018

Description:

Fix problem with Bridge v6 and CCT (tuneable white)
Related issue: fixes #11360

Checklist:

  • The code change is tested and works locally.

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@homeassistant

This comment has been minimized.

Copy link

commented Feb 10, 2018

Hello @vaceslav,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <email@address.com>"
      
      (substituting Author Name and email@address.com for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

@homeassistant

This comment has been minimized.

Copy link

commented Feb 10, 2018

Hi @vaceslav,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@balloob balloob merged commit a9e2dd3 into home-assistant:dev Feb 10, 2018

5 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.975%
Details
hound No violations found. Woof!

@balloob balloob added this to the 0.63 milestone Feb 10, 2018

balloob added a commit that referenced this pull request Feb 10, 2018

Update limitlessled requirement to v1.0.9 (#12275)
* Update limitlessled requirement to v1.0.9

* trigger cla

* take back empty line

@balloob balloob referenced this pull request Feb 10, 2018

Merged

0.63 #12267

@RiRomain

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2018

This seems to have broken my limitless led component:

2018-02-11 01:06:38 ERROR (MainThread) [homeassistant.components.light] Error while setting up platform limitlessled
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 84, in async_setup
SLOW_SETUP_MAX_WAIT, loop=hass.loop)
File "/usr/local/lib/python3.6/asyncio/tasks.py", line 352, in wait_for
return fut.result()
File "/usr/local/lib/python3.6/asyncio/futures.py", line 244, in result
raise self._exception
File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 55, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/local/lib/python3.6/site-packages/homeassistant/components/light/limitlessled.py", line 119, in setup_platform
'fade': group_conf[CONF_FADE]
File "/usr/local/lib/python3.6/site-packages/homeassistant/components/light/limitlessled.py", line 177, in factory
return LimitlessLEDRGBWGroup(group, config)
File "/usr/local/lib/python3.6/site-packages/homeassistant/components/light/limitlessled.py", line 258, in init
self.group.white()
File "/config/deps/lib/python3.6/site-packages/limitlessled/group/rgbw.py", line 56, in white
cmd = self.command_set.white()
AttributeError: 'CommandSetRgbwV6' object has no attribute 'white'

Might not be this change that broke it, but it seems to be the only change concerning limitless led, or was there something else in 0.63?

hmn added a commit to hmn/home-assistant-dev that referenced this pull request Feb 11, 2018

Merge branch 'dev' into smappee
* dev: (313 commits)
  check_config check bootstrap errors (home-assistant#12291)
  have climate fallback to state if no ATTR_OPERATION_MODE (home-assistant#12271) (home-assistant#12279)
  Update limitlessled requirement to v1.0.9 (home-assistant#12275)
  Retry keyset cloud (home-assistant#12270)
  allow wildcards in subscription (home-assistant#12247)
  Update limitlessled requirement to v1.0.9 (home-assistant#12275)
  Retry keyset cloud (home-assistant#12270)
  Fix some rfxtrx devices with multiple sensors (home-assistant#12264)
  allow wildcards in subscription (home-assistant#12247)
  device_tracker.asuswrt: Clean up unused connection param (home-assistant#12262)
  Version bump to 0.64.0.dev0
  Version bump to 0.63
  One bug fix and one improvement to the statistics sensor. (home-assistant#12259)
  Update frontend to 20180209.0
  Fix duplicate entity_ids in System Monitor (home-assistant#12124)
  Fix for iTunes media player not updating artwork (home-assistant#12089)
  Update owntracks.py (home-assistant#12260)
  Update pyhomematic to 0.1.39 (home-assistant#12265)
  miflora - fix for exception handling bug (home-assistant#12149)
  Fix source code using Windows newline (home-assistant#12248)
  ...

hmn added a commit to hmn/home-assistant-dev that referenced this pull request Feb 11, 2018

Merge branch 'dev' into ps4
* dev: (190 commits)
  check_config check bootstrap errors (home-assistant#12291)
  have climate fallback to state if no ATTR_OPERATION_MODE (home-assistant#12271) (home-assistant#12279)
  Update limitlessled requirement to v1.0.9 (home-assistant#12275)
  Retry keyset cloud (home-assistant#12270)
  allow wildcards in subscription (home-assistant#12247)
  Update limitlessled requirement to v1.0.9 (home-assistant#12275)
  Retry keyset cloud (home-assistant#12270)
  Fix some rfxtrx devices with multiple sensors (home-assistant#12264)
  allow wildcards in subscription (home-assistant#12247)
  device_tracker.asuswrt: Clean up unused connection param (home-assistant#12262)
  Version bump to 0.64.0.dev0
  Version bump to 0.63
  One bug fix and one improvement to the statistics sensor. (home-assistant#12259)
  Update frontend to 20180209.0
  Fix duplicate entity_ids in System Monitor (home-assistant#12124)
  Fix for iTunes media player not updating artwork (home-assistant#12089)
  Update owntracks.py (home-assistant#12260)
  Update pyhomematic to 0.1.39 (home-assistant#12265)
  miflora - fix for exception handling bug (home-assistant#12149)
  Fix source code using Windows newline (home-assistant#12248)
  ...

@amelchio amelchio referenced this pull request Feb 14, 2018

Merged

Downgrade limitlessled to 1.0.8 #12403

5 of 6 tasks complete

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.