Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 3 small issues in isy994 component #12421

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Projects
None yet
3 participants
@OverloadUT
Copy link
Contributor

commented Feb 15, 2018

Description:

Three tiny fixes that were still lingering from my big cleanup in #11243

  1. FanLincs have two nodes: one light and one fan motor. In order for each node to get detected as different Hass entity types, I removed the device-type check for FanLinc. The logic will now fall back on the uom checks which should work just fine. (An alternative approach here would be to special case FanLincs and handle them directly - but seeing as the newer 5.x ISY firmware already handles this much better using NodeDefs, I think this quick and dirty approach is fine for the older firmware.) Fixes #12030

  2. Some non-dimming switches were appearing as lights in Hass due to an duplicate NodeDef being in the light domain filter. Removed! Fixes #12340

  3. The unqiue_id property was throwing an error for certain entity types that don't have an _id property from the ISY. This issue has always been present, but was exposed by the entity registry which seems to be the first thing to actually try reading the unique_id property from the isy994 component.

Breaking Change Notes

Some non-dimming switches were getting detected as light entities rather than switch entities for users on ISY 5.x firmware. The issue has been fixed, which means that some light entities will go back to being switches, as they always should have been.

Related issue (if applicable): fixes #12030 and #12340

Pull request in home-assistant.github.io with documentation (if applicable): No documentation update

Checklist:

  • The code change is tested and works locally.
Fixed 3 small issues in isy994 component
1. FanLincs have two nodes: one light and one fan motor. In order for each node to get detected as different Hass entity types, I removed the device-type check for FanLinc. The logic will now fall back on the uom checks which should work just fine. (An alternative approach here would be to special case FanLincs and handle them directly - but seeing as the newer 5.x ISY firmware already handles this much better using NodeDefs, I think this quick and dirty approach is fine for the older firmware.) Fixes #12030
2. Some non-dimming switches were appearing as `light`s in Hass due to an duplicate NodeDef being in the light domain filter. Removed! Fixes #12340
3. The `unqiue_id` property was throwing an error for certain entity types that don't have an `_id` property from the ISY. This issue has always been present, but was exposed by the entity registry which seems to be the first thing to actually try reading the `unique_id` property from the isy994 component.

@balloob balloob merged commit c25c4c8 into home-assistant:dev Feb 15, 2018

4 of 5 checks passed

coverage/coveralls Coverage pending from Coveralls.io
Details
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@balloob balloob added this to the 0.63.3 milestone Feb 15, 2018

hmn added a commit to hmn/home-assistant-dev that referenced this pull request Feb 15, 2018

Merge branch 'dev' into smappee
* dev:
  Print every changed file on new line (home-assistant#12412)
  Fix MQTT payload decode returning prematurely (home-assistant#12420)
  Fixed 3 small issues in isy994 component (home-assistant#12421)
  Extract data validator to own file and add tests (home-assistant#12401)
  Upgrade sphinx-autodoc-typehints to 1.2.5 (home-assistant#12404)
  Code cleanup of velux scene (home-assistant#12390)

@OverloadUT OverloadUT deleted the OverloadUT:fix-isy994-device-detection branch Feb 15, 2018

balloob added a commit that referenced this pull request Feb 17, 2018

Fixed 3 small issues in isy994 component (#12421)
1. FanLincs have two nodes: one light and one fan motor. In order for each node to get detected as different Hass entity types, I removed the device-type check for FanLinc. The logic will now fall back on the uom checks which should work just fine. (An alternative approach here would be to special case FanLincs and handle them directly - but seeing as the newer 5.x ISY firmware already handles this much better using NodeDefs, I think this quick and dirty approach is fine for the older firmware.) Fixes #12030
2. Some non-dimming switches were appearing as `light`s in Hass due to an duplicate NodeDef being in the light domain filter. Removed! Fixes #12340
3. The `unqiue_id` property was throwing an error for certain entity types that don't have an `_id` property from the ISY. This issue has always been present, but was exposed by the entity registry which seems to be the first thing to actually try reading the `unique_id` property from the isy994 component.

@balloob balloob referenced this pull request Feb 17, 2018

Merged

0.63.3 #12484

@OverloadUT OverloadUT referenced this pull request Feb 22, 2018

Merged

Fix fix isy994 fan detection #12595

2 of 2 tasks complete

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.