Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: timeout data attribute now is parsed to float #12432

Merged
merged 1 commit into from Feb 15, 2018

Conversation

@sjvc
Copy link
Contributor

commented Feb 15, 2018

Description:

Telegram bot accepts timeout as data parameter, but when using it, it fails because it cannot convert string to float. This fix defines timeout in service schema, so it's converted to float.

Checklist:

  • The code change is tested and works locally.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.
@balloob balloob merged commit f0d9e5d into home-assistant:dev Feb 15, 2018
5 checks passed
5 checks passed
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 94.073%
Details
hound No violations found. Woof!
@balloob balloob referenced this pull request Feb 22, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.