Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WUnderground spamming logs #12548

Merged
merged 1 commit into from Feb 20, 2018

Conversation

@OttoWinter
Copy link
Member

commented Feb 20, 2018

Description:

See #12517 for a detailed explanation. This is option 1 - never invalidate valid data.

Related issue (if applicable): fixes #12517

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: wunderground
    api_key: !secret wunderground_api_key
    monitored_conditions:
      - weather
      - weather_1d_metric
      - weather_1n_metric

Checklist:

  • The code change is tested and works locally.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Should I add tests? If so, how can I best trigger an update to all entities?

@balloob balloob merged commit f2a2727 into home-assistant:dev Feb 20, 2018
4 of 5 checks passed
4 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
coverage/coveralls Coverage decreased (-0.009%) to 94.055%
Details
hound No violations found. Woof!
@balloob balloob referenced this pull request Feb 22, 2018
@bacumings

This comment has been minimized.

Copy link

commented Mar 13, 2018

Hi,
Apologies if this isn't the right place to report this, but I'm seeing these errors in my logs again. Running 0.65.2. Please let me know if there is somewhere else this should go.

screenshot_2018-03-13-14-38-55

@OttoWinter OttoWinter deleted the OttoWinter:fix-wunderground-spam branch Mar 13, 2018
@OttoWinter

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2018

Hmmm, it seems like this only fixed part of the issue. Apparently WUnderground is sometimes sending out invalid JSON to us 🤕. I'm seeing the same thing now on my installation, but unfortunately it is quite hard to reproduce and appears only quite seldomly.

I have now put a log into my installation that will hopefully allow me to further debug the issue. If you have additional please use the #12517 issue, I'll reopen it. Thanks :)

@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.