Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting state from iglo #12685

Merged
merged 1 commit into from Feb 27, 2018

Conversation

Projects
None yet
3 participants
@jesserockz
Copy link
Contributor

commented Feb 26, 2018

Description:

Upgrade iGlo library and revert to using lamp.state() as a method instead of @property which is not working in production docker images.

Checklist:

  • The code change is tested and works locally.

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
@balloob

This comment has been minimized.

Copy link
Member

commented Feb 27, 2018

Thanks!

@balloob balloob merged commit d052d45 into home-assistant:dev Feb 27, 2018

5 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 94.054%
Details
hound No violations found. Woof!

@balloob balloob added this to the 0.64.1 milestone Feb 27, 2018

balloob added a commit that referenced this pull request Feb 27, 2018

@balloob balloob referenced this pull request Feb 27, 2018

Merged

0.64.1 #12742

@jesserockz

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2018

@balloob I develop on my mac but my system is running on docker on my RPi, What Dockerfile(s) do I need to build to get an image so I can test it out in my environment?

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.