Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alpha_vantage default options #12726

Merged
merged 1 commit into from Feb 27, 2018

Conversation

Projects
None yet
3 participants
@ChristianKuehnel
Copy link
Contributor

commented Feb 26, 2018

Description:

fixed bug in parsing config data. Now undefined symbols or foreign_exchanges to not trigger an exception any more

Related issue (if applicable): fixes #12673

Pull request in home-assistant.github.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

  - platform: alpha_vantage
    api_key: <api key>
    symbols:
    - symbol: MSFT

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.64.1 milestone Feb 27, 2018

@balloob balloob merged commit 6bdb2fe into home-assistant:dev Feb 27, 2018

5 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 94.054%
Details
hound No violations found. Woof!

@MartinHjelmare MartinHjelmare changed the title fix for https://github.com/home-assistant/home-assistant/issues/ Fix alpha_vantage default options Feb 27, 2018

balloob added a commit that referenced this pull request Feb 27, 2018

@balloob balloob referenced this pull request Feb 27, 2018

Merged

0.64.1 #12742

@ChristianKuehnel ChristianKuehnel deleted the ChristianKuehnel:alphafix branch Mar 18, 2018

@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.