Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix harmony duplicate detection #12729

Merged
merged 1 commit into from Feb 27, 2018

Conversation

@amelchio
Copy link
Contributor

commented Feb 26, 2018

Description:

The matching was wrong so manually configured devices would show up twice if discovery was enabled.

Related issue (if applicable): reported in https://community.home-assistant.io/t/2-harmony-hubs-basic-config-errors/44886/3

Checklist:

  • The code change is tested and works locally.

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully.
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@arsaboo

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2018

We should include this in 0.64.1

@amelchio

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2018

It should be safe to do that but this issue is not new. As far as I can tell, it has been there forever.

@balloob balloob added this to the 0.64.1 milestone Feb 27, 2018
@balloob

This comment has been minimized.

Copy link
Member

commented Feb 27, 2018

Small enough for 0.64.1 👍

@balloob balloob merged commit 98fef81 into home-assistant:dev Feb 27, 2018
5 checks passed
5 checks passed
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.003%) to 94.051%
Details
hound No violations found. Woof!
balloob added a commit that referenced this pull request Feb 27, 2018
@balloob balloob referenced this pull request Feb 27, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.