Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xiaomi MiIO Vacuum: Use a unique data key per domain #12743

Merged
merged 2 commits into from Feb 28, 2018

Conversation

Projects
None yet
3 participants
@syssi
Copy link
Member

commented Feb 27, 2018

Service calls of foreign domains (light.xiaomi_miio, fan.xiaomi_miio) reached all xiaomi_miio devices in the past because all xiaomi_miio components shared a common data key.

@balloob

This comment has been minimized.

Copy link
Member

commented Feb 27, 2018

tests need fixing.

@syssi

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2018

Upala. I will care about!

SERVICE_MOVE_REMOTE_CONTROL, SERVICE_MOVE_REMOTE_CONTROL_STEP,
SERVICE_START_REMOTE_CONTROL, SERVICE_STOP_REMOTE_CONTROL)
from homeassistant.const import (
ATTR_ENTITY_ID, ATTR_SUPPORTED_FEATURES, CONF_PLATFORM, STATE_OFF,
STATE_ON)
from homeassistant.setup import async_setup_component

PLATFORM = 'xiaomi_miio'

This comment has been minimized.

Copy link
@balloob

balloob Feb 28, 2018

Member

Don't use this, just import DATA_KEY ?

This comment has been minimized.

Copy link
@syssi

This comment has been minimized.

Copy link
@balloob

balloob Feb 28, 2018

Member

oh ok. Sorry.

@balloob balloob merged commit 222748d into home-assistant:dev Feb 28, 2018

5 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 94.018%
Details
hound No violations found. Woof!

@balloob balloob referenced this pull request Mar 9, 2018

Merged

0.65 #12995

@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.