Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence harmless sonos data structure warnings #12767

Merged

Conversation

Projects
None yet
3 participants
@amelchio
Copy link
Contributor

commented Feb 27, 2018

Description:

The recent Sonos rework increased the allowed logging because it appeared that SoCo did not produce logs at that level in normal operation.

However, a frequent but harmless warning has now been reported. This PR turns the logging level back down for the module emitting that warning.

I have not yet managed to produce the warning myself so the change is untested for the time being.

Related issue (if applicable): fixes #12745

Checklist:

  • The code change is tested and works locally.

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully.
  • New dependencies have been added to the REQUIREMENTS variable.
  • New dependencies are only imported inside functions that use them.
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@amelchio amelchio added this to the 0.64.2 milestone Feb 27, 2018

@balloob balloob merged commit f19b934 into home-assistant:dev Feb 28, 2018

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
coverage/coveralls Coverage decreased (-0.009%) to 94.01%
Details
hound No violations found. Woof!

balloob added a commit that referenced this pull request Mar 1, 2018

@balloob balloob referenced this pull request Mar 1, 2018

Merged

0.64.2 #12808

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.