Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfluxDB cleanups #12903

Merged
merged 3 commits into from Mar 4, 2018

Conversation

Projects
None yet
3 participants
@amelchio
Copy link
Contributor

commented Mar 4, 2018

Description:

Three changes that are so small that I thought I would put them in a single PR:

  1. Remove retry_queue_limit that was deprecated in 0.63
  2. Properly close the influxdb connection on shutdown
  3. Do not attempt to store very large integers as "inf" because InfluxDB will reject it. This can happen rather easily when we try turning "2017-06-12 00:00:00.000" into the integer 20170612000000000.

Related issue (if applicable): fixes #8530

Checklist:

  • The code change is tested and works locally.

If the code does not interact with devices:

  • Local tests with tox run successfully.
  • Tests have been added to verify that the new code works.

amelchio added some commits Feb 25, 2018

@MartinHjelmare
Copy link
Member

left a comment

Looks good!

@MartinHjelmare MartinHjelmare merged commit d418355 into home-assistant:dev Mar 4, 2018

5 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0003%) to 94.038%
Details
hound No violations found. Woof!

@balloob balloob referenced this pull request Mar 9, 2018

Merged

0.65 #12995

@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.