Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tibber: Check if the current electricity price is available before we… #12905

Merged
merged 2 commits into from Mar 5, 2018

Conversation

Projects
None yet
4 participants
@Danielhiversen
Copy link
Member

commented Mar 4, 2018

Description:

Check if the current electricity price is available before we ask for new prices.

Changed to await syntax

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: tibber
    access_token: d1007ead2dc84a2b82f0de19451c5fb22112f7ae11d19bf2bedb224a003ff74a

Checklist:

  • The code change is tested and works locally.
Daniel Høyer Iversen
await self._tibber_home.update_info()
await self._tibber_home.update_price_info()
data = self._tibber_home.info['viewer']['home']
self._device_state_attributes['App nickname'] = data['appNickname']

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Mar 4, 2018

Member

Attributes should be lowercase snakecase.

Daniel Høyer Iversen
@MartinHjelmare
Copy link
Member

left a comment

Looks good! Can be merged when build passes.

@balloob balloob merged commit 7c7da9d into dev Mar 5, 2018

6 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0003%) to 94.038%
Details
hound No violations found. Woof!

@balloob balloob deleted the tibber_cache branch Mar 5, 2018

@balloob balloob referenced this pull request Mar 9, 2018

Merged

0.65 #12995

@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.