Refactor Google Assistant #12959
We tried to get our Google Assistant integration certified by Google and we ran into a couple of issues #12935.
When I was looking into fixing the bugs, I realized that the code could benefit from a major cleaning. I've followed a similar model as we used for Alexa and have structured all the logic based on the traits that Google supports.
Because of this, I have removed a few hacks:
I'm running the old tests on the new code without modification. Will add some new tests for the new code on top of that too with as goal to replace the old tests too. The old tests test too many things at once, making it difficult to test specific code paths.
This refactor will open up the way to easily implement a ton more traits easily. Especially excited about the Toggles trait that can turn things on/off.
Breaking change: Google Assistant has removed the
Related issue (if applicable): #12935
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
If the code does not interact with devices:
referenced this pull request
Mar 7, 2018
Mar 8, 2018
6 checks passed
@balloob I have actual lights that are switches in home assistant (due to how the rfxcom component works). I used the override to let them show up as lights in Google assistant and enable queries such as "turn on all living room lights". What is the recommended way to handle this case now?
light.group will actually not work as it is limited to lights. The reason for removing it is that all of Google Assistant works by testing against