Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HomeKit Bugfix: Error for string values #13162

Merged
merged 1 commit into from Mar 14, 2018

Conversation

Projects
None yet
3 participants
@cdce8p
Copy link
Member

commented Mar 13, 2018

Description:

Fixed error that occurred if a climate device wasn't reporting a valid temperature as int or float.

Related issue (if applicable): fixes #12868 (comment)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.
@cdce8p

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2018

Just waiting for conformation that this solves the issue, since I can't test it myself. Otherwise ready.

@cdce8p cdce8p added this to the 0.65.5 milestone Mar 13, 2018

@bieniu

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2018

I confirm, the fix works.

@cdce8p cdce8p changed the title WIP: HomeKit Bugfix: Error for string values HomeKit Bugfix: Error for string values Mar 14, 2018

@cdce8p cdce8p merged commit c48c871 into home-assistant:dev Mar 14, 2018

5 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.078%
Details
hound No violations found. Woof!

@cdce8p cdce8p deleted the cdce8p:homekit-bugfix-temperature branch Mar 14, 2018

balloob added a commit that referenced this pull request Mar 14, 2018

@balloob balloob referenced this pull request Mar 14, 2018

Merged

0.65.5 #13223

engrbm87 added a commit to engrbm87/home-assistant that referenced this pull request Mar 20, 2018

engrbm87 pushed a commit to engrbm87/home-assistant that referenced this pull request Apr 16, 2018

@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.