Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input_boolean Google Assistant serialize error #13220

Merged
merged 1 commit into from Mar 14, 2018

Conversation

Projects
None yet
3 participants
@balloob
Copy link
Member

commented Mar 14, 2018

Description:

Fix Google Assistant serializing input booleans.

Related issue (if applicable): fixes #13153, fixes #13110

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@OttoWinter
Copy link
Member

left a comment

Looks good to me 👍

@balloob balloob merged commit e1a5e5a into dev Mar 14, 2018

6 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.886%
Details
hound No violations found. Woof!

@balloob balloob deleted the google-assistant-input-boolean branch Mar 14, 2018

balloob added a commit that referenced this pull request Mar 14, 2018

@balloob balloob referenced this pull request Mar 14, 2018

Merged

0.65.5 #13223

@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.