Cleanup homematicip_cloud #13356
Cleanup homematicip_cloud #13356
Conversation
|
|
||
| from socket import timeout |
There was a problem hiding this comment.
socket is part of standard library in python.
There was a problem hiding this comment.
But seems I need to import socket in order to used it for "except timeout:" later.
There was a problem hiding this comment.
Yes. I'm just saying that the blank line should go between import socket and import voluptuous as vol.
| self._home = home | ||
| self._device = device | ||
|
|
||
| @asyncio.coroutine | ||
| def async_added_to_hass(self): |
There was a problem hiding this comment.
Drop the coroutine decorator and define the method with async def async_added_to_hass(self):.
| _LOGGER.debug('Setting up access point %s', home.label) | ||
|
|
||
| @asyncio.coroutine | ||
| def async_added_to_hass(self): |
MartinHjelmare
changed the title
| @@ -2,14 +2,14 @@ | |||
| Support for HomematicIP sensors. | |||
|
|
|||
| For more details about this component, please refer to the documentation at | |||
| https://home-assistant.io/components/homematicip/ | |||
| https://home-assistant.io/components/homematicip_cloud/ | |||
There was a problem hiding this comment.
This url is still not correct. Look at other sensor platforms for the correct format.
There was a problem hiding this comment.
Hmm, it looks like im still not 100% used to the git branch flow, as I already started to implement new devices as well... sorry.
|
Can be merged when build passes. |
ghost
removed
the
Description:
Cleanup of the initial PR
Checklist:
tox. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.