Bugfix Thermostat Fahrenheit support #13477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* util -> temperature_to_homekit * util -> temperature_to_states * util -> convert_to_float
cdce8p
changed the title
OttoWinter
reviewed
Mar 27, 2018
|
|
||
|
|
||
| def temperature_to_states(temperature, unit): | ||
| """Convert temperature back form Celsius to Home Assistant unit.""" |
There was a problem hiding this comment.
There was a problem hiding this comment.
I want to preserve the original unit of the climate device. That's why I only use util.temperature.convert.
fabaff
changed the title
balloob
pushed a commit
that referenced
this pull request
Mar 30, 2018
* Bugfix thermostat temperature conversion * util -> temperature_to_homekit * util -> temperature_to_states * util -> convert_to_float * Added tests, deleted log msg
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes unit missing unit conversion from Fahrenheit to Celsius (from HomeKit).
Related issue (if applicable): fixes #13463
Checklist:
tox. Your PR cannot be merged unless tests pass