Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting light brightness #13518

Merged
merged 1 commit into from Mar 29, 2018
Merged

Fix setting light brightness #13518

merged 1 commit into from Mar 29, 2018

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Mar 28, 2018 •
edited

Description:

Fixed issue where setting the brightness, in special cases, resulted in two turn_on calls.

Related issue: fixes #13493

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Reported and suggested by: @DaveOke

@cdce8p cdce8p added this to the 0.66 milestone Mar 28, 2018
@cdce8p cdce8p merged commit cea2de5 into home-assistant:dev Mar 29, 2018
@cdce8p cdce8p deleted the homekit-fix-lights branch March 29, 2018 16:36
@fabaff fabaff changed the title HomeKit: Fix setting light brightness Fix setting light brightness Mar 29, 2018
balloob pushed a commit that referenced this pull request Mar 30, 2018
@cdce8p @balloob
HomeKit: Fix setting light brightness (#13518)
0428559 
* Added test
@balloob balloob mentioned this pull request Mar 30, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug cherry-picked cla-signed integration: homekit
Projects
None yet
Milestone
0.66
Development

Successfully merging this pull request may close these issues.

Homekit - Cannot reliably set brightness level
3 participants
@cdce8p @balloobbot @homeassistant