Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump python-ecobee-api version to 0.0.18 #13854

Merged
merged 2 commits into from Apr 14, 2018

Conversation

Projects
None yet
3 participants
@geekofweek
Copy link
Contributor

commented Apr 13, 2018

Description:

Bump python-ecobee-api version to 0.0.18

This resolved an issue caused by a Typo that prevented Ecobee from utilizing nextTransition when setting a hold mode or temperature.

Related issue (if applicable): fixes #

nkgilley/python-ecobee-api#33

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
@balloob

This comment has been minimized.

Copy link
Member

commented Apr 13, 2018

Please read the PR template and fill it in

@balloob balloob merged commit c6c1666 into home-assistant:dev Apr 14, 2018

4 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 94.139%
Details
@balloob

This comment has been minimized.

Copy link
Member

commented Apr 14, 2018

Thanks! 🐬

@geekofweek geekofweek deleted the geekofweek:python-ecobee-api==0.0.18 branch Apr 14, 2018

@balloob balloob referenced this pull request Apr 27, 2018

Merged

0.68 #14124

@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.