Zone - Hass configuration name is optional #14449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
integration: zone
core
small-pr
Kane610
changed the title
Kane610
changed the title
Kane610
changed the title
syssi
reviewed
May 21, 2018
|
|
||
| if HOME_ZONE not in hass.data[DOMAIN] and HOME_ZONE not in zone_entries: | ||
| name = hass.config.location_name | ||
| if name is None: |
There was a problem hiding this comment.
It's possible apply a proper default to location_name?
There was a problem hiding this comment.
That is hass own parameter. This is how the old logic worked. I just missed this use case
…, where many zones can have the same name
houndci-bot
reviewed
May 30, 2018
tests/components/zone/test_init.py
Outdated
| 'latitude': 1.1, | ||
| 'longitude': -2.2, | ||
| } | ||
| assert setup.setup_component(self.hass, zone.DOMAIN, {'zone': [info, info]}) |
There was a problem hiding this comment.
line too long (84 > 79 characters)
balloob
approved these changes
Jun 7, 2018
ghost
removed
the
balloob
pushed a commit
that referenced
this pull request
Jun 8, 2018
* Hass configuration name is optional * Check explicitly if name is none * Reverted back to old logic for zones configured in configuration.yaml, where many zones can have the same name * New test to verify use case of allowing multiple zones having the same name * Fix too long line
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Hass configuration option name is optional, make sure there is a name for the home zone
Related issue (if applicable): fixes #14396
Checklist:
tox. Your PR cannot be merged unless tests pass