New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend package support #14611

Merged
merged 1 commit into from May 25, 2018

Conversation

Projects
None yet
3 participants
@cdce8p
Member

cdce8p commented May 24, 2018

Description:

Added package support for sections the previously where only allowed once, through recursive merging.
This could be useful for components that support filtering, as you are now able to define the filter in multiple packages.

Pull request in home-assistant.github.io with documentation: home-assistant/home-assistant.io#5425

Example entry for configuration.yaml (if applicable):

# Example for the HomeKit filter

# Configuration
homekit:
  auto_start: False
  filter:
    include_domains:
      - switch

# Package
homekit:
  filter:
    include_domains:
      - lights
    include_entities:
      - climate.demo
      - climate.test

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • Documentation added/updated in home-assistant.github.io
  • Tests have been added to verify that the new code works.

CC: @kellerza

@cdce8p cdce8p requested a review from home-assistant/core as a code owner May 24, 2018

@cdce8p cdce8p referenced this pull request May 24, 2018

Merged

Extend packages support #5425

2 of 2 tasks complete

@cdce8p cdce8p added the new-feature label May 24, 2018

@balloob balloob merged commit 6ceafab into home-assistant:dev May 25, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 94.007%
Details

@cdce8p cdce8p deleted the cdce8p:packages branch May 25, 2018

iMicknl added a commit to iMicknl/home-assistant that referenced this pull request May 31, 2018

@balloob balloob referenced this pull request Jun 8, 2018

Merged

0.71.0 #14876

@cdce8p cdce8p referenced this pull request Jun 15, 2018

Merged

Fix extended package support #14980

2 of 3 tasks complete

cyberjacob pushed a commit to cyberjacob/home-assistant that referenced this pull request Sep 4, 2018

@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.