Update mqtt_eventstream.py #14923
Merged
Update mqtt_eventstream.py #14923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a line setting an internal state mqtt_eventstream.initialized to True since: 1. No other platform is doing this 2. This will create an annoying entity/item in the user interface which the user will have to explicitly hide
homeassistant
added
cla-signed
integration: mqtt_eventstream
small-pr
ghost
assigned 
houndci-bot
reviewed
Jun 11, 2018
| @@ -115,6 +115,5 @@ def _event_receiver(topic, payload, qos): | |||
| # Only subscribe if you specified a topic. | |||
| if sub_topic: | |||
| yield from mqtt.async_subscribe(sub_topic, _event_receiver) | |||
|
|
|||
| hass.states.async_set('{domain}.initialized'.format(domain=DOMAIN), True) | |||
|
|
|||
|
What was the reason behind this line when it was added? |
|
Seems like it has been in place since the component was created: 8ace656#diff-c847158c00eebfb12ba4f2a8e0927aaeR93 I would guess it was once used for debugging and then forgotten. |
MartinHjelmare
approved these changes
Jun 11, 2018
fabaff
approved these changes
Jun 11, 2018
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Update mqtt_eventstream.py Remove a line setting an internal state mqtt_eventstream.initialized to True since: 1. No other platform is doing this 2. This will create an annoying entity/item in the user interface which the user will have to explicitly hide * Update mqtt_eventstream.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a line setting an internal state
mqtt_eventstream.initializedtoTruesince:Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: