Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize mysensors #15123

Merged
merged 3 commits into from Jun 25, 2018

Conversation

Projects
None yet
3 participants
@MartinHjelmare
Copy link
Member

commented Jun 24, 2018

Description:

  • Prepare for config entries and component services.
  • Move mysensors component to package.
  • Split code into multiple modules.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • New files were added to .coveragerc.

MartinHjelmare added some commits Jun 24, 2018

Move mysensors component to package
* Split code into multiple modules.

@ghost ghost assigned MartinHjelmare Jun 24, 2018

@ghost ghost added the in progress label Jun 24, 2018

@pvizeli
Copy link
Member

left a comment

Good cleanup. Some stuff like setup_mysensors_platform are hard to read and also the validate part is not like my slogan, keep it simple and smart, but they was also in the old one.

@pvizeli pvizeli merged commit 3893d8a into home-assistant:dev Jun 25, 2018

4 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 94.08%
Details

@ghost ghost removed the in progress label Jun 25, 2018

@MartinHjelmare

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2018

Thanks @pvizeli! Yes, I'll think about how to improve those functions.

eavanvalkenburg added a commit to eavanvalkenburg/home-assistant that referenced this pull request Jun 28, 2018

Reorganize mysensors (home-assistant#15123)
* Move mysensors.py to package

* Move mysensors component to package

* Split code into multiple modules.

* Update coveragerc

@balloob balloob referenced this pull request Jul 6, 2018

Merged

0.73 #15330

MizterB added a commit to MizterB/home-assistant that referenced this pull request Aug 11, 2018

Reorganize mysensors (home-assistant#15123)
* Move mysensors.py to package

* Move mysensors component to package

* Split code into multiple modules.

* Update coveragerc

cyberjacob pushed a commit to cyberjacob/home-assistant that referenced this pull request Sep 4, 2018

Reorganize mysensors (home-assistant#15123)
* Move mysensors.py to package

* Move mysensors component to package

* Split code into multiple modules.

* Update coveragerc

@MartinHjelmare MartinHjelmare deleted the MartinHjelmare:reorganize-mysensors branch Oct 11, 2018

@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.