Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LIFX color/temperature attributes mutually exclusive #15234

Merged
merged 1 commit into from Jul 1, 2018

Conversation

amelchio
Copy link
Contributor

@amelchio amelchio commented Jun 30, 2018

Description:

Since a light cannot be white and colored at the same time, this PR changes LIFX to only report one of the hs_color/color_temp attributes. LIFX does not have separate color/white modes so we treat it as white when the color is fully desaturated.

Breaking change: LIFX will no longer report hs_color/rgb_color and color_temp simultaneously.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@ghost ghost assigned amelchio Jun 30, 2018
@ghost ghost added the in progress label Jun 30, 2018
@balloob balloob added this to the 0.73 milestone Jul 1, 2018
@balloob balloob merged commit dffe367 into home-assistant:dev Jul 1, 2018
@ghost ghost removed the in progress label Jul 1, 2018
@balloob balloob mentioned this pull request Jul 6, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants