Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Tahoma Smoke Sensor #15441

Merged
merged 1 commit into from Jul 18, 2018

Conversation

Projects
None yet
3 participants
@fucm
Copy link
Contributor

commented Jul 13, 2018

Description:

Add support for Tahoma Smoke Sensor: rtds:RTDSSmokeSensor.
Added special icon for the smoke sensor, if fire is detected or the battery is low.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5590

Example entry for configuration.yaml (if applicable):

nothing

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • No new dependencies.
  • New file already covered by components/*/tahoma.py (.coveragerc).

If the code does not interact with devices:

  • N/A (interacts with devices).
@balloob

This comment has been minimized.

Copy link
Member

commented Jul 18, 2018

Awesome!

@balloob balloob merged commit 6834e00 into home-assistant:dev Jul 18, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.905%
Details

@ghost ghost removed the in progress label Jul 18, 2018

michaeldavie added a commit to michaeldavie/home-assistant that referenced this pull request Jul 31, 2018

@balloob balloob referenced this pull request Aug 3, 2018

Merged

0.75.0 #15806

@fucm fucm deleted the fucm:tahoma-binary-sensor branch Aug 10, 2018

MizterB added a commit to MizterB/home-assistant that referenced this pull request Aug 11, 2018

cyberjacob pushed a commit to cyberjacob/home-assistant that referenced this pull request Sep 4, 2018

@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.