New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switchmate #15535

Merged
merged 8 commits into from Aug 29, 2018

Conversation

Projects
None yet
4 participants
@Danielhiversen
Member

Danielhiversen commented Jul 18, 2018

Description:

Swichmate is a bluetooth switch https://www.mysimplysmarthome.com/products/switchmate-switches/

There are only 3 lines with device specific code, so I decided to not split it to an external library.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6031

Example entry for configuration.yaml (if applicable):

switch:
  - platform: switchmate
    mac: 'cb:25:0b......'
    name: "Name of the device"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Danielhiversen added some commits Jul 17, 2018

@frenck frenck added the docs-missing label Jul 21, 2018

@Danielhiversen Danielhiversen referenced this pull request Aug 17, 2018

Merged

Adds Switchmate documentation #6031

1 of 2 tasks complete
@MartinHjelmare

Looks good. Note my comment about exception info though. We usually don't include all that in error logs. We settle for the exception argument.

@Danielhiversen

This comment has been minimized.

Show comment
Hide comment
@Danielhiversen

Danielhiversen Aug 29, 2018

Member

@MartinHjelmare : Can I merge this, or do you want someone else to take a look?

Member

Danielhiversen commented Aug 29, 2018

@MartinHjelmare : Can I merge this, or do you want someone else to take a look?

@MartinHjelmare

This comment has been minimized.

Show comment
Hide comment
@MartinHjelmare

MartinHjelmare Aug 29, 2018

Member

Yes, go ahead and merge. I've approved it.

Member

MartinHjelmare commented Aug 29, 2018

Yes, go ahead and merge. I've approved it.

@Danielhiversen Danielhiversen merged commit 18ba50b into dev Aug 29, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 93.741%
Details

@wafflebot wafflebot bot removed the in progress label Aug 29, 2018

@Danielhiversen Danielhiversen deleted the switchmate branch Aug 29, 2018

cyberjacob pushed a commit to cyberjacob/home-assistant that referenced this pull request Sep 4, 2018

Switchmate (home-assistant#15535)
* Switchmate

* switchmate

* swithcmate

* switchmate

* switchmate

* fix comments

* Update switchmate.py

* change error log

@balloob balloob referenced this pull request Sep 17, 2018

Merged

0.78.0 #16666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment