New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct wemo static device discovery issue. #16292

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Projects
None yet
3 participants
@lamiskin
Contributor

lamiskin commented Aug 30, 2018

A recent change caused an issue if a single static wemo device is offline and could not be reached, then the whole component would not initialize (and therefore all other wemo devices are not added).

Description:

As described in the comments of the latest release blog:

mnl​1121
If you have a Wemo switch unplugged and explicitly set each Wemo switch in your config, none of your wemo plugs will work. It throws an error about not being able to find the one and then none work. I have 3 wemo switches and sometimes I unplug one. Previous HA versions never had a problem, now they do.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Correct wemo static device discovery issue.
A recent change caused an issue if a single static wemo device is offline and could not be reached, then the whole component would not initialize (and therefore all other wemo devices are not added).
@homeassistant

This comment has been minimized.

homeassistant commented Aug 30, 2018

Hi @lamiskin,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@balloob balloob added this to the 0.77.2 milestone Aug 31, 2018

@balloob balloob merged commit 93f4577 into home-assistant:dev Aug 31, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot All contributors have signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on patch-1 at 93.743%
Details

@wafflebot wafflebot bot removed the in progress label Aug 31, 2018

balloob added a commit that referenced this pull request Aug 31, 2018

Correct wemo static device discovery issue. (#16292)
A recent change caused an issue if a single static wemo device is offline and could not be reached, then the whole component would not initialize (and therefore all other wemo devices are not added).

@balloob balloob referenced this pull request Aug 31, 2018

Merged

0.77.2 #16324

cyberjacob pushed a commit to cyberjacob/home-assistant that referenced this pull request Sep 4, 2018

Correct wemo static device discovery issue. (home-assistant#16292)
A recent change caused an issue if a single static wemo device is offline and could not be reached, then the whole component would not initialize (and therefore all other wemo devices are not added).

@lamiskin lamiskin deleted the lamiskin:patch-1 branch Sep 5, 2018

@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.