New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTherm Gateway climate platform #16299

Merged
merged 12 commits into from Sep 7, 2018

Conversation

Projects
None yet
4 participants
@mvn23
Contributor

mvn23 commented Aug 30, 2018

Description:

Add support for the OpenTherm Gateway.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6118

Example entry for configuration.yaml (if applicable):

climate:
  - platform: opentherm_gw
    device: /dev/ttyUSB0

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

mvn23 added some commits Aug 29, 2018

Fix coveragerc and requirements_all*.txt
Overall cleanup and polishing

@mvn23 mvn23 referenced this pull request Aug 30, 2018

Merged

Documentation for OpenTherm Gateway climate platform #6118

2 of 2 tasks complete
Show resolved Hide resolved homeassistant/components/climate/opentherm_gw.py Outdated
Show resolved Hide resolved homeassistant/components/climate/opentherm_gw.py Outdated
Show resolved Hide resolved homeassistant/components/climate/opentherm_gw.py Outdated
Show resolved Hide resolved homeassistant/components/climate/opentherm_gw.py Outdated
Show resolved Hide resolved homeassistant/components/climate/opentherm_gw.py Outdated
Show resolved Hide resolved homeassistant/components/climate/opentherm_gw.py Outdated
Show resolved Hide resolved homeassistant/components/climate/opentherm_gw.py Outdated
Show resolved Hide resolved homeassistant/components/climate/opentherm_gw.py Outdated
Show resolved Hide resolved homeassistant/components/climate/opentherm_gw.py Outdated
Show resolved Hide resolved homeassistant/components/climate/opentherm_gw.py Outdated

@mvn23 mvn23 changed the title from Add OpenTherm Gateway climate component. to [WIP] Add OpenTherm Gateway climate component. Sep 4, 2018

@mvn23

This comment has been minimized.

Contributor

mvn23 commented Sep 4, 2018

Thank you for the very thorough review. Looks like there is still quite some work to do, but that was expected since it's my first real contribution to Home Assistant. I will address all concerns over the next few days.

@mvn23 mvn23 changed the title from [WIP] Add OpenTherm Gateway climate component. to [WIP] Add OpenTherm Gateway climate platform. Sep 5, 2018

Basic improvements to comply with Home Assistant's style guidelines
Changed wording from "component" to more appropriate terms where necessary
Fixed small mistakes that snuck in during testing and/or due to my own ignorance ;)

mvn23 added some commits Sep 5, 2018

Fixed a bug with ROOM_SETPOINT_OVRD
Updated dependency pyotgw to latest version

mvn23 added some commits Sep 5, 2018

@mvn23 mvn23 changed the title from [WIP] Add OpenTherm Gateway climate platform. to Add OpenTherm Gateway climate platform Sep 5, 2018

@mvn23 mvn23 closed this Sep 5, 2018

@wafflebot wafflebot bot removed the in progress label Sep 5, 2018

@mvn23 mvn23 reopened this Sep 5, 2018

@wafflebot wafflebot bot added the in progress label Sep 5, 2018

@MartinHjelmare

Shouldn't polling be set to False for this entity?

@mvn23

This comment has been minimized.

Contributor

mvn23 commented Sep 5, 2018

Shouldn't polling be set to False for this entity?

I've been looking for a way to do this, but could not find it in the dev docs before. Seems I missed the "Entities Introduction" part and relied too much on examples from other platforms.
I will have a look and prepare another commit tonight or tomorrow.
Thanks for the feedback!

Disable polling for this platform
Improve update flow
@MartinHjelmare

Nice! Two small comments.

Show resolved Hide resolved homeassistant/components/climate/opentherm_gw.py Outdated
Show resolved Hide resolved homeassistant/components/climate/opentherm_gw.py Outdated
@MartinHjelmare

Great!

@MartinHjelmare MartinHjelmare merged commit 7ad094b into home-assistant:dev Sep 7, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 93.767%
Details

@wafflebot wafflebot bot removed the in progress label Sep 7, 2018

@mvn23 mvn23 deleted the mvn23:opentherm-gateway branch Sep 8, 2018

@balloob balloob referenced this pull request Sep 17, 2018

Merged

0.78.0 #16666

@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.