New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LIFX effects #16309

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Projects
None yet
4 participants
@amelchio
Member

amelchio commented Aug 30, 2018

Description:

The changes in #15980 broke LIFX effects by renaming the self.device attribute to self.light but unfortunately missing a light.device usage in a list comprehension.

This PR fixes that and consistently renames device/light to bulb to make it more clear that it is not a Light (but actually an aiolifx.Light).

I also added myself as code owner for LIFX so I can hopefully catch issues like this earlier.

Related issue (if applicable): fixes #16286

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@pvizeli pvizeli merged commit b43c47c into home-assistant:dev Aug 31, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on lifx-rename-device at 93.765%
Details

@wafflebot wafflebot bot removed the in progress label Aug 31, 2018

balloob added a commit that referenced this pull request Aug 31, 2018

@balloob balloob referenced this pull request Aug 31, 2018

Merged

0.77.2 #16324

cyberjacob pushed a commit to cyberjacob/home-assistant that referenced this pull request Sep 4, 2018

@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.