New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New EDP re:dy component #16426

Merged
merged 15 commits into from Sep 15, 2018

Conversation

Projects
None yet
4 participants
@abmantis
Contributor

abmantis commented Sep 4, 2018

Description:

New integration of the EDP re:dy platform.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6200

Example entry for configuration.yaml (if applicable):

edp_redy:
  username: YOUR_USERNAME
  password: YOUR_PASSWORD

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New files were added to .coveragerc.

abmantis added some commits Sep 1, 2018

@wafflebot wafflebot bot added the in progress label Sep 4, 2018

@abmantis abmantis changed the title from new EDP re:dy component to New EDP re:dy component Sep 4, 2018

@abmantis abmantis referenced this pull request Sep 4, 2018

Merged

Add docs for new EDP re:dy component #6200

2 of 2 tasks complete
@MartinHjelmare

The EdpRedySession class should be extracted.

Show resolved Hide resolved homeassistant/components/edp_redy.py Outdated
from edp_redy import EdpRedySession

session = EdpRedySession(config[DOMAIN][CONF_USERNAME],
config[DOMAIN][CONF_PASSWORD])

This comment has been minimized.

@houndci-bot

houndci-bot Sep 6, 2018

continuation line over-indented for visual indent

abmantis added some commits Sep 7, 2018

@abmantis

This comment has been minimized.

Contributor

abmantis commented Sep 7, 2018

By the way, is the following lint issue a false positive?
homeassistant/components/edp_redy.py:57:19: E0601: Using variable 'platform_loaded' before assignment (used-before-assignment)

@MartinHjelmare

Please follow our style guide for quotes. There are some inconsistencies.

https://developers.home-assistant.io/docs/en/development_guidelines.html#quotes

Show resolved Hide resolved homeassistant/components/sensor/edp_redy.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/edp_redy.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/edp_redy.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/edp_redy.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/edp_redy.py Outdated
Show resolved Hide resolved homeassistant/components/switch/edp_redy.py Outdated
Show resolved Hide resolved homeassistant/components/switch/edp_redy.py Outdated
Show resolved Hide resolved homeassistant/components/switch/edp_redy.py Outdated
Show resolved Hide resolved homeassistant/components/switch/edp_redy.py Outdated
Show resolved Hide resolved homeassistant/components/switch/edp_redy.py Outdated

abmantis added some commits Sep 9, 2018

@abmantis

This comment has been minimized.

Contributor

abmantis commented Sep 9, 2018

Thanks for the suggestions @MartinHjelmare ! Nice catch on the entity updates refactoring, it is better now.

await discovery.async_load_platform(hass, component,
DOMAIN, {}, config)
platform_loaded = True

This comment has been minimized.

@houndci-bot

houndci-bot Sep 9, 2018

blank line contains whitespace

@abmantis

This comment has been minimized.

Contributor

abmantis commented Sep 11, 2018

Is there any way to fix the following lint issue? Or is it a false positive?
homeassistant/components/edp_redy.py:57:19: E0601: Using variable 'platform_loaded' before assignment (used-before-assignment)

@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Sep 11, 2018

Not sure. Logic looks sane to me.

@abmantis

This comment has been minimized.

Contributor

abmantis commented Sep 11, 2018

OK, thanks. Do you see anything else to do before merging?

@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Sep 12, 2018

Disable that pylint error for now. After that I think we're good. 👍

@abmantis

This comment has been minimized.

Contributor

abmantis commented Sep 15, 2018

@MartinHjelmare this still shows that you are requesting changes. Is there anything else or you just forgot to resolve?

@MartinHjelmare MartinHjelmare merged commit 9c9df79 into home-assistant:dev Sep 15, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.005%) to 93.768%
Details

@wafflebot wafflebot bot removed the in progress label Sep 15, 2018

@abmantis abmantis deleted the abmantis:platform_edp_redy branch Sep 15, 2018

@balloob balloob referenced this pull request Sep 28, 2018

Merged

0.79.0 #16940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment