New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Starling Bank #16522

Merged
merged 6 commits into from Sep 18, 2018

Conversation

Projects
None yet
5 participants
@Dullage
Contributor

Dullage commented Sep 9, 2018

Description:

Added support for Starling Bank.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6236

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: starlingbank
    accounts:
      - name: "Spending Money"
        sandbox: false
        access_token: YOUR_PERSONAL_ACCESS_TOKEN
        balance_types:
          - 'cleared_balance'
          - 'effective_balance'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Dullage added some commits Sep 9, 2018

@homeassistant

This comment has been minimized.

homeassistant commented Sep 9, 2018

Hi @Dullage,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Show resolved Hide resolved homeassistant/components/sensor/starlingbank.py Outdated
Show resolved Hide resolved .coveragerc Outdated
Show resolved Hide resolved homeassistant/components/sensor/starlingbank.py Outdated

@Dullage Dullage changed the title from Added support for Starling Bank to WIP: Added support for Starling Bank Sep 10, 2018

@homeassistant

This comment was marked as resolved.

homeassistant commented Sep 10, 2018

Hello @Dullage,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <email@address.com>"
      
      (substituting Author Name and email@address.com for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

@Dullage Dullage changed the title from WIP: Added support for Starling Bank to Added support for Starling Bank Sep 11, 2018

@dgomes dgomes removed the cla-error label Sep 14, 2018

@fabaff

fabaff approved these changes Sep 18, 2018

@fabaff fabaff merged commit 56b0d2e into home-assistant:dev Sep 18, 2018

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.07%) to 93.696%
Details

@wafflebot wafflebot bot removed the in progress label Sep 18, 2018

})


def setup_platform(hass, config, add_devices, discovery_info=None):

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Sep 18, 2018

Member

We have renamed add_devices to add_entities.

This comment has been minimized.

@Dullage

Dullage Sep 20, 2018

Contributor

Thanks @MartinHjelmare, I think I'm write in saying this is just a cosmetic thing? If so, would it be a good idea for me to wrap this rename up in a bigger change at a later date?

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Sep 20, 2018

Member

Yes, nothing is broken like this. 👍

But it's nice to keep everything in sync to allow future smooth migrations.

@balloob balloob referenced this pull request Sep 28, 2018

Merged

0.79.0 #16940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment