New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image support to hangouts notifications #16560

Merged
merged 20 commits into from Sep 25, 2018

Conversation

Projects
None yet
5 participants
@quazzie
Contributor

quazzie commented Sep 11, 2018

Description:

Adds image support to hangouts notification

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6254

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

quazzie added some commits Sep 11, 2018

add image support
Add image support to hangouts notification.
Show resolved Hide resolved homeassistant/components/hangouts/hangouts_bot.py Outdated
Show resolved Hide resolved homeassistant/components/hangouts/hangouts_bot.py Outdated
Show resolved Hide resolved homeassistant/components/hangouts/hangouts_bot.py Outdated
Show resolved Hide resolved homeassistant/components/hangouts/hangouts_bot.py Outdated
Show resolved Hide resolved homeassistant/components/hangouts/hangouts_bot.py Outdated
Show resolved Hide resolved homeassistant/components/hangouts/hangouts_bot.py Outdated
Show resolved Hide resolved homeassistant/components/hangouts/hangouts_bot.py Outdated
Show resolved Hide resolved homeassistant/components/hangouts/hangouts_bot.py Outdated
Show resolved Hide resolved homeassistant/components/hangouts/hangouts_bot.py Outdated
Show resolved Hide resolved homeassistant/components/hangouts/hangouts_bot.py Outdated

@quazzie quazzie referenced this pull request Sep 11, 2018

Merged

Add image support for hangouts notification #6254

2 of 2 tasks complete

quazzie added some commits Sep 11, 2018

Add data schema
forgot schema

quazzie added some commits Sep 12, 2018

quazzie added some commits Sep 12, 2018

@pvizeli

Instead to try to validate the url use a schematic like other notify platforms like:

{
   "photo": [
       "file": "...",
       "url": "...",
   ]
}

Or simple:

{
   "image_file": "",
   "image_url": "",
}

You can self select your style, but don't use this urlparse handling.

Examples:

After that it should be ready to merge.

change to image_file/url (#3)
* change to image_file/url

quazzie added some commits Sep 14, 2018

@quazzie

This comment has been minimized.

Contributor

quazzie commented Sep 21, 2018

@pvizeli this ok ?

@pvizeli

This comment has been minimized.

Member

pvizeli commented Sep 25, 2018

We should create a helper in future

@pvizeli pvizeli merged commit bc8d323 into home-assistant:dev Sep 25, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.07%) to 93.687%
Details

@wafflebot wafflebot bot removed the in progress label Sep 25, 2018

@quazzie quazzie deleted the quazzie:patch-2 branch Sep 25, 2018

@balloob

This comment has been minimized.

Member

balloob commented Oct 5, 2018

So this PR added incorrect YAML to services.yaml which caused Home Assistant to not boot at all. Which begs the question, did anyone run this PR @quazzie ?

@quazzie

This comment has been minimized.

Contributor

quazzie commented Oct 8, 2018

Hmm :( sorry last commit (rename to image_file/_url) was made with github edit as i was away so no that last commit was not run. Stupid mistake, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment