Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Call Data Log platform. Mailboxes no longer require media #16579
This patch adds the asterisk_cdr mailbox platform to view call activity. It also makes it possible to dynamically create mailbox platforms (needed in case CDR isn't supplied by the server). Additionally, mailboxes without media are now supported, as are read-only messages, making the mailbox platform more generic. Lastly all asycio.coroutines have been migrated to async/await.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6264
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Sep 17, 2018
@MartinHjelmare Thanks for the review. Moving those async calls to sync uncovered a real race condition. Is there any way to detect async calls made from the wrong thread to help prevent these types of errors?
I believe I have resolved all of your concerns.
Sorry, I wasn't clear. I meant that changing to using the sync versions uncovered a timing race which I have already fixed. I was just wondering in general about checkers to help find these types of issues before I submit patches