Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logbook context #16937

Merged
merged 6 commits into from Oct 1, 2018

Conversation

Projects
None yet
3 participants
@balloob
Copy link
Member

commented Sep 28, 2018

Description:

Enhances logbook with:

  • Remove Entry class if we're just going to JSONify it right away. Create dict right away
  • context (requires frontend change to be visible)
  • show incoming Alexa commands

Example entry for configuration.yaml (if applicable):

logbook:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

balloob added some commits Sep 28, 2018

@balloob balloob requested a review from home-assistant/core as a code owner Sep 28, 2018

balloob added some commits Sep 28, 2018

@pvizeli

pvizeli approved these changes Oct 1, 2018

@pvizeli pvizeli merged commit fbc1c41 into dev Oct 1, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 93.533%
Details

@pvizeli pvizeli deleted the logbook-context branch Oct 1, 2018

@wafflebot wafflebot bot removed the in progress label Oct 1, 2018

@balloob balloob referenced this pull request Oct 12, 2018

Merged

0.80.0 #17361

@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.