Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for ElkM1 alarm/automation panel #16952
Support for the ElkM1 alarm/automation panel. This has been in development for around 6 months. A number of people have installed and have been testing the code as a custom_component.
Looking for feedback on how to improve.
Related issue (if applicable): fixes #
Example entry for
Thanks for the PR. First strip this PR down to only add the elkm1 component and the alarm_control_panel platform. Further platforms should be added one platform and PR at a time. We want PRs to be as small as possible to make review and merge quicker.
I've commented on the component and the alarm_control_panel platform.
At this point it feels like we're arguing more than trying to get this PR merged. I'm happy to answer questions but defending the home assistant architecture is not what this PR review should be about. Please continue that discussion in the dev discord chat or in our architecture repo.