New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Maps supports battery level and charging. #16969

Merged
merged 6 commits into from Sep 30, 2018

Conversation

Projects
None yet
6 participants
@htotoo
Contributor

htotoo commented Sep 29, 2018

With 3.0.2 locationsharinglib now the battery level and the charging attributes are available.

Description:

This also fixes some other bugs, mentioned here: https://github.com/costastf/locationsharinglib/issues?q=is%3Aissue+is%3Aclosed

Related issue (if applicable): fixes #16947 #15076

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Google Maps supports battery level and charging.
With 3.0.2 locationsharinglib now the battery level and the charging attributes are available.
@@ -11,13 +11,13 @@
from homeassistant.components.device_tracker import (
PLATFORM_SCHEMA, SOURCE_TYPE_GPS)
from homeassistant.const import ATTR_ID, CONF_PASSWORD, CONF_USERNAME
from homeassistant.const import ATTR_ID, CONF_PASSWORD, CONF_USERNAME, ATTR_BATTERY_CHARGING, ATTR_BATTERY_LEVEL

This comment has been minimized.

@houndci-bot

houndci-bot Sep 29, 2018

line too long (112 > 79 characters)

Update google_maps.py
fix too long line error
@bachya

Looks good with one small change. Additionally, note that you need to update your requirements with script/gen_requirements_all.py.

@@ -12,12 +12,13 @@
from homeassistant.components.device_tracker import (
PLATFORM_SCHEMA, SOURCE_TYPE_GPS)
from homeassistant.const import ATTR_ID, CONF_PASSWORD, CONF_USERNAME
from homeassistant.const import ATTR_BATTERY_CHARGING, ATTR_BATTERY_LEVEL

This comment has been minimized.

@bachya

bachya Sep 29, 2018

Contributor

Don't split imports from a single module into two statements.

This comment has been minimized.

@htotoo

htotoo Sep 29, 2018

Contributor

Fixed it.

htotoo added some commits Sep 29, 2018

Update google_maps.py
Fix multi line import, and line length limit
Update gen_requirements_all.py
Add locationsharinglib to gen_requirements_all
@fabaff

fabaff approved these changes Sep 30, 2018

Thanks 🐦

@fabaff fabaff merged commit 1b7bfec into home-assistant:dev Sep 30, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 93.569%
Details

@wafflebot wafflebot bot removed the in progress label Sep 30, 2018

@htotoo htotoo deleted the htotoo:patch-1 branch Sep 30, 2018

@@ -63,6 +63,7 @@
'influxdb',
'libpurecoollink',
'libsoundtouch',
'locationsharinglib',

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Sep 30, 2018

Member

There are no tests for this platform, right?

This comment has been minimized.

@htotoo

htotoo Oct 1, 2018

Contributor

Can't figure out how to pass the Tarvis tests :(

fabaff added a commit that referenced this pull request Oct 1, 2018

@fabaff fabaff referenced this pull request Oct 1, 2018

Merged

Upgrade locationsharinglib to 3.0.3 #17010

2 of 2 tasks complete

balloob added a commit that referenced this pull request Oct 1, 2018

Upgrade locationsharinglib to 3.0.3 (#17010)
* Upgrade locationsharinglib to 3.0.3

* Revert change from #16969

@balloob balloob referenced this pull request Oct 12, 2018

Merged

0.80.0 #17361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment