New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alexa to simply turn on and off climate components. #16989

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
4 participants
@Parlane
Contributor

Parlane commented Sep 30, 2018

Description:

Some climate devices keep the last mode of operation and it makes sense to simply ask Alexa to turn them off and on, this is different than having an "off" operation mode.

For instance here is my web UI control for my heatpump:
image

Examples for alexa:

"alexa turn off the heatpump": heatpump is commanded off and alexa says "Ok"
"alexa turn on the heatpump": heatpump is commanded on and alexa says "Ok"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

homeassistant commented Sep 30, 2018

Hi @Parlane,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@@ -501,6 +501,9 @@ def default_display_categories(self):
return [_DisplayCategory.THERMOSTAT]
def interfaces(self):
supported = self.entity.attributes.get(ATTR_SUPPORTED_FEATURES, 0)
if supported & climate.SUPPORT_ON_OFF:
yield _AlexaPowerController(self.entity)

This comment has been minimized.

@houndci-bot

houndci-bot Sep 30, 2018

indentation is not a multiple of four

@homeassistant homeassistant added cla-signed and removed cla-needed labels Sep 30, 2018

@Parlane Parlane force-pushed the Parlane:climate-power-controller branch from 002dc3d to a88ca1d Sep 30, 2018

@balloob

balloob approved these changes Nov 6, 2018

@balloob balloob merged commit 7933bd7 into home-assistant:dev Nov 6, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 93.567%
Details

@wafflebot wafflebot bot removed the in progress label Nov 6, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment