New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hue discovery on manual configuration #17070

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
5 participants
@balloob
Member

balloob commented Oct 2, 2018

Description:

We used to allow hue: to be configured in configuration.yaml without any options. This would then trigger a discovery of hubs and then set them up. When we moved to config entries, the logic changed to discover and them import them. This allowed people transitioning to import their auth.

This logic was introduced on March 30. Now it's time to sunset this behavior.

Related issue (if applicable): fixes #17025

Example entry for configuration.yaml (if applicable):

hue:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@wafflebot wafflebot bot added the in progress label Oct 2, 2018

@balloob balloob changed the title from Remove discovery to Remove Hue discovery on manual configuration Oct 2, 2018

@bachya bachya added the Hacktoberfest label Oct 2, 2018

@pvizeli

pvizeli approved these changes Oct 4, 2018

All PRs they remove more code as new is a good PR :D

@pvizeli pvizeli merged commit 769dda7 into dev Oct 4, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on hue-remove-discovery at 93.7%
Details

@pvizeli pvizeli deleted the hue-remove-discovery branch Oct 4, 2018

@wafflebot wafflebot bot removed the in progress label Oct 4, 2018

@balloob balloob referenced this pull request Oct 12, 2018

Merged

0.80.0 #17361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment