Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faucet, shower, sprinkler, valve to HomeKit #17145

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
2 participants
@cdce8p
Copy link
Member

commented Oct 4, 2018

Description:

I've added the long requested switch types: faucet, shower, sprinkler and valve.

img_1008

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6515

Example entry for configuration.yaml (if applicable):

homekit:
  entity_config:
    switch.my_faucet:
      type: faucet
    switch.my_shower:
      type: shower
    switch.my_sprinkler:
      type: sprinkler
    switch.my_valve:
      type: valve

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • Documentation added/updated in home-assistant.io
  • Tests have been added to verify that the new code works.

@wafflebot wafflebot bot added the in progress label Oct 4, 2018

@cdce8p cdce8p referenced this pull request Oct 4, 2018

Merged

Added new switch types homekit #6515

2 of 2 tasks complete

@cdce8p cdce8p changed the title WIP: Add faucet, shower, sprinkler, valve to HomeKit Add faucet, shower, sprinkler, valve to HomeKit Oct 4, 2018

@cdce8p cdce8p merged commit 37a47b5 into home-assistant:dev Oct 5, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 93.632%
Details

@wafflebot wafflebot bot removed the in progress label Oct 5, 2018

@cdce8p cdce8p deleted the cdce8p:homekit-new-switch-types branch Oct 5, 2018

@balloob balloob referenced this pull request Oct 12, 2018

Merged

0.80.0 #17361

@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.