New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device tracking for the BT Smart Hub router #17158

Merged
merged 22 commits into from Oct 23, 2018

Conversation

Projects
None yet
6 participants
@jxwolstenholme
Contributor

jxwolstenholme commented Oct 5, 2018

Description:

Added support for device tracking for the BT Smart Hub router (UK). Might it be sensible to collect this with the bt_home_hub_5 component in some way - perhaps to share a page on home-assistant.io ?

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6528

Example entry for configuration.yaml (if applicable):

# Example configuration.yaml entry
device_tracker:
  - platform: bt_smarthub
    host: 192.168.1.254

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

jxwolstenholme added some commits Oct 5, 2018

@homeassistant

This comment has been minimized.

homeassistant commented Oct 5, 2018

Hi @jxwolstenholme,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@homeassistant

This comment has been minimized.

homeassistant commented Oct 5, 2018

Hi @jxwolstenholme,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@homeassistant

This comment has been minimized.

homeassistant commented Oct 5, 2018

Hi @jxwolstenholme,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@homeassistant homeassistant added cla-signed and removed cla-needed labels Oct 5, 2018

jxwolstenholme added some commits Oct 5, 2018

jxwolstenholme added some commits Oct 5, 2018

jxwolstenholme added some commits Oct 8, 2018

@bachya bachya added the Hacktoberfest label Oct 9, 2018

jxwolstenholme added some commits Oct 10, 2018

@MartinHjelmare

Great!

@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Oct 11, 2018

Can be merged when build passes.

@MartinHjelmare MartinHjelmare changed the title from Adding support for device tracking for the BT Smart Hub router to Add device tracking for the BT Smart Hub router Oct 11, 2018

import homeassistant.helpers.config_validation as cv
from homeassistant.components.device_tracker import (DOMAIN,
PLATFORM_SCHEMA, DeviceScanner)

This comment has been minimized.

@houndci-bot

houndci-bot Oct 23, 2018

line too long (84 > 79 characters)

import voluptuous as vol
import homeassistant.helpers.config_validation as cv
from homeassistant.components.device_tracker import (DOMAIN,

This comment has been minimized.

@houndci-bot

houndci-bot Oct 23, 2018

trailing whitespace

@MartinHjelmare MartinHjelmare merged commit 7be7a8d into home-assistant:dev Oct 23, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 93.584%
Details

@wafflebot wafflebot bot removed the in progress label Oct 23, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment