Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add LogBook support to HomeKit #17180
Initial set to add HomeKit entries to LogBook. Setting the framework for it.
If the code does not interact with devices:
It is working on mine. When I start HASS I get entries in LogBook about the accessories that have been added to HomeKit. It provides the accessory type and the friendly name.
Then when I unlock (or lock) the door it puts in logbook an entry like:
Front Door here is my display name.
Left a few comments. Mostly about unnecessary empty lines
Personally I think we should move the
logbook changes to a new PR, but we could leave them in there until the rest is done to make live testing easier.
Already looking much better now!
Will do an in deep review tomorrow but wanted to leave you some quick comments.
Can you try moving the logger debug statment to call_service as well?
Just two quick comments.
After these I think we only need to update the tests, expand to all other types and we are done.
Good work so far!
When you change the other types, make sure to rebase your branch. I'm not 100% sure there haven't been any updates:
As for tests: I'll take a look at them later and get back to you.
requested review from
Oct 9, 2018
@cdce8p Well, that rebase did not work out as it should. Made a mistake and resulted in a whole bunch of other commit being part of my branch and part of my commits.
Updated all the other types for HomeKit and are part of this last commit.
I went ahead and pushed some changes to your branch. Take a look at the last commits.
Take a look at my changes to
Before you start working on it, make sure to fetch your remote branch first and then rebase your local branch onto it, so you have my commits as well.