Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport NSW #17242

Merged
merged 4 commits into from Oct 11, 2018

Conversation

Projects
None yet
4 participants
@Dav0815
Copy link
Contributor

commented Oct 8, 2018

Description:

New sensor to request leave times from Transport NSW (Australia).

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6529

Example entry for configuration.yaml (if applicable):

- platform: transport_nsw
  stop_id: '209516'
  route:  '199'
  api_key: 'YOUR_API_KEY'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@Dav0815
Copy link
Contributor Author

left a comment

Fixed

Show resolved Hide resolved homeassistant/components/sensor/transport_nsw.py Outdated
@MartinHjelmare
Copy link
Member

left a comment

Fix the lint issue, and run script/gen_requirements.py again and commit the changes and this should be good to go.

Show resolved Hide resolved homeassistant/components/sensor/transport_nsw.py Outdated

@bachya bachya added the Hacktoberfest label Oct 9, 2018

@MartinHjelmare MartinHjelmare changed the title Transport NSW - Resubmission of development Transport NSW Oct 10, 2018

@MartinHjelmare
Copy link
Member

left a comment

Great!

@MartinHjelmare MartinHjelmare merged commit c6c5d40 into home-assistant:dev Oct 11, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on TransportNSW at 93.491%
Details

@wafflebot wafflebot bot removed the in progress label Oct 11, 2018

@Dav0815 Dav0815 deleted the Dav0815:TransportNSW branch Oct 12, 2018

@balloob balloob referenced this pull request Oct 26, 2018

Merged

0.81 #17809

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Nov 1, 2018

We don't support custom components.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Nov 1, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.