New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Lock #17288

Merged
merged 6 commits into from Oct 11, 2018

Conversation

Projects
None yet
5 participants
@Anonym-tsk
Contributor

Anonym-tsk commented Oct 9, 2018

Description:

New Template Lock component.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6642

Example entry for configuration.yaml (if applicable):

lock:
  - platform: template
    name: Garage door
    value_template: "{{ is_state('sensor.door', 'on') }}"
    lock:
      service: switch.turn_on
      data:
        entity_id: switch.door
    unlock:
      service: switch.turn_off
      data:
        entity_id: switch.door

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Anonym-tsk added some commits Oct 9, 2018

@wafflebot wafflebot bot added the in progress label Oct 9, 2018

@Anonym-tsk Anonym-tsk referenced this pull request Oct 9, 2018

Merged

Template Lock #6642

2 of 2 tasks complete

@bachya bachya added the Hacktoberfest label Oct 9, 2018

@balloob

This comment has been minimized.

Member

balloob commented Oct 10, 2018

Please add the logic that we don't track templates if they have result in MATCH_ALL. See this example

@balloob balloob merged commit 2a35a39 into home-assistant:dev Oct 11, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 93.459%
Details

@wafflebot wafflebot bot removed the in progress label Oct 11, 2018

@balloob balloob referenced this pull request Oct 26, 2018

Merged

0.81 #17809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment