Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved econet from climate to water heater #17322

Merged
merged 3 commits into from Oct 13, 2018

Conversation

Projects
None yet
5 participants
@w1ll1am23
Copy link
Collaborator

commented Oct 11, 2018

Description:

This PR moves econet water heaters to the new water_heater component added with #17058

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6676

Example entry for configuration.yaml (if applicable):

water_heater:
  - platform: econet
    username: test@test.com
    password: test1234

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

w1ll1am23 added some commits Oct 11, 2018

@MartinHjelmare
Copy link
Member

left a comment

Looks good!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Oct 12, 2018

Please add a paragraph in the description that highlights the breaking change for the release notes.

@fabaff

This comment has been minimized.

Copy link
Member

commented Oct 13, 2018

Breaking change:

The econet climate platform was moved to the new water heater implementation. Please update your configuration, use water_heater now.

@fabaff fabaff merged commit 6a8eb8d into home-assistant:dev Oct 13, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 93.48%
Details

@wafflebot wafflebot bot removed the in progress label Oct 13, 2018

@w1ll1am23

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 13, 2018

@fabaff thanks I am on vacation so wouldn't be able to get to it for a few days.

@balloob balloob referenced this pull request Oct 26, 2018

Merged

0.81 #17809

@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.