Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix netio component #17411

Merged
merged 3 commits into from Oct 13, 2018
Merged

Fix netio component #17411

merged 3 commits into from Oct 13, 2018

Conversation

J4nsen
Copy link
Contributor

@J4nsen J4nsen commented Oct 13, 2018

Description:

This fixes two issues:

  • hardcoded login credentials in pynetio by bumping the required version.
  • a type error in the netio component of home assistant.

Related issue: fixes #14246 #14245

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@homeassistant
Copy link
Contributor

Hi @J4nsen,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ghost ghost added the in progress label Oct 13, 2018
@fabaff fabaff changed the title fix netio component Fix netio component Oct 13, 2018
fabaff
fabaff approved these changes Oct 13, 2018
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit d0da265 into home-assistant:dev Oct 13, 2018
@ghost ghost removed the in progress label Oct 13, 2018
@balloob balloob mentioned this pull request Oct 26, 2018
Merged
@derandiunddasbo
Copy link

Works for me as well. Thanks!

@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees
No one assigned
Labels
cla-signed Hacktoberfest integration: netio small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

netio switch component doesn't work with a netio-230B device
4 participants
@J4nsen @homeassistant @derandiunddasbo @fabaff