New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove day as a config option in speedtest sensor #17452

Merged
merged 1 commit into from Oct 14, 2018

Conversation

Projects
None yet
6 participants
@kennedyshead
Contributor

kennedyshead commented Oct 14, 2018

Description:

This removes the day configuration.

Breaking change: The configuration option day has been removed from the speedtest sensor.

Related issue (if applicable): fixes #17352

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6807

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

@kennedyshead

This comment has been minimized.

Contributor

kennedyshead commented Oct 14, 2018

This is a breaking change

@amelchio

Looks good 👍. Please add a "Breaking change" paragraph that can be copy/pasted into the release notes.

@kennedyshead

This comment has been minimized.

Contributor

kennedyshead commented Oct 14, 2018

@amelchio like that?

@kennedyshead kennedyshead changed the title from Remove day as a conf option to Remove day as a config option in speedtest component (Breaking change) Oct 14, 2018

@amelchio amelchio changed the title from Remove day as a config option in speedtest component (Breaking change) to Remove day as a config option in speedtest sensor Oct 14, 2018

@kennedyshead

This comment has been minimized.

Contributor

kennedyshead commented Oct 14, 2018

Ty ;)

@amelchio

This comment has been minimized.

Member

amelchio commented Oct 14, 2018

Like that :)

@fabaff fabaff merged commit 1187e0a into home-assistant:dev Oct 14, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.547%
Details

@wafflebot wafflebot bot removed the in progress label Oct 14, 2018

@kennedyshead kennedyshead deleted the kennedyshead:speedtest_fix branch Oct 15, 2018

@balloob balloob referenced this pull request Oct 26, 2018

Merged

0.81 #17809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment