Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Migrate Mailgun to use the webhook component #17464
Migrating Mailgun over to the webhook API so that it doesn't need an api password.
This is built on top of #17460 (which is approved and needs to be merged before this one).
Breaking Change: Each instance of Home Assistant will now generate it's own unique webhook url for Mailgun to use. One will need to be generated and provided to Mailgun for incoming messages from Mailgun to Home Assistant to continue to flow.
I followed the approach used in #16817 to implement a new config flow to register the webhook. Existing configuration (api key, domain) still occurs via the configuration.yaml file.
I will update the documentation and unit tests once this gets an initial look. I want to validate that the approach makes sense first.
Related issue (if applicable): Related to #15376
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
If the code does not interact with devices:
Oct 16, 2018
I'm thinking we can also delete this unit test: https://github.com/home-assistant/home-assistant/blob/dev/tests/components/ifttt/test_init.py#L41 since that logic no longer exists in the component itself and is tested by the helper tests here: https://github.com/home-assistant/home-assistant/pull/17464/files#diff-f51b5c565fd30e4d50c767f79eda1988R186
This was referenced
Oct 23, 2018
Documentation updated and I added a section on this being a breaking change.
Once this is merged in, there should be a follow up PR where we implement the Making It Secure section from the Mailgun guide (this was never previously implemented in Home Assistant).