New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix eventstream with EOF on end #17465

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Projects
None yet
3 participants
@pvizeli
Member

pvizeli commented Oct 15, 2018

Description:

With aiohttp > 3.2.0 we need return the StreamResponse back to aiohttp core that they write a EOF to stream. Some clients (also aiohttp) never close the reading if they not see a EOF on end of the stream.

@pvizeli pvizeli requested a review from home-assistant/core as a code owner Oct 15, 2018

@wafflebot wafflebot bot added the in progress label Oct 15, 2018

@balloob balloob added this to the 0.80.1 milestone Oct 15, 2018

@balloob balloob merged commit 3b0db29 into dev Oct 15, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 93.548%
Details

@wafflebot wafflebot bot removed the in progress label Oct 15, 2018

@balloob balloob deleted the fix-event branch Oct 15, 2018

@balloob balloob referenced this pull request Oct 15, 2018

Merged

Fix websocket API #17471

3 of 3 tasks complete

balloob added a commit that referenced this pull request Oct 15, 2018

@balloob balloob referenced this pull request Oct 15, 2018

Merged

0.80.1 #17480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment